habanalabs: change the write flag name of error info structs

positive flags naming will make more clear code while adding
more 'error info' structures

Signed-off-by: Tal Cohen <talcohen@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>

diff --git a/drivers/misc/habanalabs/common/command_submission.c b/drivers/misc/habanalabs/common/command_submission.c
index fb30b7de4aab27904f634ca95ce2147807b59765..22109be0613963bd005aa9f295c160a816126ded 100644 (file)
--- a/drivers/misc/habanalabs/common/command_submission.c
+++ b/drivers/misc/habanalabs/common/command_submission.c
@@ -735,8 +735,8 @@ static void cs_timedout(struct work_struct *work)
        hdev = cs->ctx->hdev;
 
        /* Save only the first CS timeout parameters */
-       rc = atomic_cmpxchg(&hdev->last_error.cs_timeout.write_disable, 0, 1);
-       if (!rc) {
+       rc = atomic_cmpxchg(&hdev->last_error.cs_timeout.write_enable, 1, 0);
+       if (rc) {
                hdev->last_error.cs_timeout.timestamp = ktime_get();
                hdev->last_error.cs_timeout.seq = cs->sequence;
        }

diff --git a/drivers/misc/habanalabs/common/habanalabs.h b/drivers/misc/habanalabs/common/habanalabs.h
index b0b0f3f898659c183f30d7188a4e6a1e1674d638..7a46f36518fe9e9ac1be8b968277c67a74a947e5 100644 (file)
--- a/drivers/misc/habanalabs/common/habanalabs.h
+++ b/drivers/misc/habanalabs/common/habanalabs.h
@@ -2570,21 +2570,21 @@ struct hl_clk_throttle {
 /**
  * struct cs_timeout_info - info of last CS timeout occurred.
  * @timestamp: CS timeout timestamp.
- * @write_disable: if set writing to CS parameters in the structure is disabled so,
- *                 the first (root cause) CS timeout will not be overwritten.
+ * @write_enable: if set writing to CS parameters in the structure is enabled. otherwise - disabled,
+ *                so the first (root cause) CS timeout will not be overwritten.
  * @seq: CS timeout sequence number.
  */
 struct cs_timeout_info {
        ktime_t         timestamp;
-       atomic_t        write_disable;
+       atomic_t        write_enable;
        u64             seq;
 };
 
 /**
  * struct razwi_info - info about last razwi error occurred.
  * @timestamp: razwi timestamp.
- * @write_disable: if set writing to razwi parameters in the structure is disabled so the
- *                 first (root cause) razwi will not be overwritten.
+ * @write_enable: if set writing to razwi parameters in the structure is enabled.
+ *                otherwise - disabled, so the first (root cause) razwi will not be overwritten.
  * @addr: address that caused razwi.
  * @engine_id_1: engine id of the razwi initiator, if it was initiated by engine that does
  *               not have engine id it will be set to U16_MAX.
@@ -2596,7 +2596,7 @@ struct cs_timeout_info {
  */
 struct razwi_info {
        ktime_t         timestamp;
-       atomic_t        write_disable;
+       atomic_t        write_enable;
        u64             addr;
        u16             engine_id_1;
        u16             engine_id_2;

diff --git a/drivers/misc/habanalabs/common/habanalabs_drv.c b/drivers/misc/habanalabs/common/habanalabs_drv.c
index 37edb69a7255cb644a6a502a182ea92241fc5f2d..e182637c2d936469dbeaea0bdc18ac6b1136eb46 100644 (file)
--- a/drivers/misc/habanalabs/common/habanalabs_drv.c
+++ b/drivers/misc/habanalabs/common/habanalabs_drv.c
@@ -195,8 +195,8 @@ int hl_device_open(struct inode *inode, struct file *filp)
 
        hl_debugfs_add_file(hpriv);
 
-       atomic_set(&hdev->last_error.cs_timeout.write_disable, 0);
-       atomic_set(&hdev->last_error.razwi.write_disable, 0);
+       atomic_set(&hdev->last_error.cs_timeout.write_enable, 1);
+       atomic_set(&hdev->last_error.razwi.write_enable, 1);
 
        hdev->open_counter++;
        hdev->last_successful_open_jif = jiffies;

diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
index 4db5f6ef96f176f3eb880157b0e0635743bce3ba..c16c0f9fe20269f5fdd03aed83c696708bf85676 100644 (file)
--- a/drivers/misc/habanalabs/gaudi/gaudi.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi.c
@@ -7410,8 +7410,8 @@ static void gaudi_print_irq_info(struct hl_device *hdev, u16 event_type,
                gaudi_print_and_get_mmu_error_info(hdev, &razwi_addr, &razwi_type);
 
                /* In case it's the first razwi, save its parameters*/
-               rc = atomic_cmpxchg(&hdev->last_error.razwi.write_disable, 0, 1);
-               if (!rc) {
+               rc = atomic_cmpxchg(&hdev->last_error.razwi.write_enable, 1, 0);
+               if (rc) {
                        hdev->last_error.razwi.timestamp = ktime_get();
                        hdev->last_error.razwi.addr = razwi_addr;
                        hdev->last_error.razwi.engine_id_1 = engine_id_1;