ravb: kill duplicate setting of CCC.CSEL
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Sat, 6 Feb 2016 14:46:35 +0000 (17:46 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Feb 2016 19:52:59 +0000 (14:52 -0500)
When  adding support for the  R-Car gen3 gPTP active in configuration mode,
the code setting the CCC.CSEL field  was duplicated due to an oversight.
For R-Car gen 2 it's just redundant  and for R-Car gen3 the write at this
time is probably  ignored due to CCC.GAC bit being already  set...

Fixes: f5d7837f96e5 ("ravb: ptp: Add CONFIG mode support")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/ravb_main.c

index ac43ed914fcf270653a6101a2f6c736b7ac2ef00..6ccef24dfd25f71f288486d85ab8c4ac60b55d3f 100644 (file)
@@ -1814,10 +1814,6 @@ static int ravb_probe(struct platform_device *pdev)
                           CCC_OPC_CONFIG | CCC_GAC | CCC_CSEL_HPB, CCC);
        }
 
-       /* Set CSEL value */
-       ravb_write(ndev, (ravb_read(ndev, CCC) & ~CCC_CSEL) | CCC_CSEL_HPB,
-                  CCC);
-
        /* Set GTI value */
        error = ravb_set_gti(ndev);
        if (error)