blktrace.c: Don't hardcode direct-io
authorLukas Straub <lukasstraub2@web.de>
Wed, 19 Jan 2022 21:14:30 +0000 (21:14 +0000)
committerJens Axboe <axboe@kernel.dk>
Thu, 20 Jan 2022 18:40:42 +0000 (11:40 -0700)
This is unexpected if one wants to test performance of a
standard filesystem (by pointing replay_redirect to a standard file)
with buffered io.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Link: https://lore.kernel.org/r/239cc0c47c346408607772fb423aa5745a3779dd.1642626314.git.lukasstraub2@web.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
blktrace.c

index f1dbd1a6fd4851a75984fe1a48090bd79afcfef2..7682a4d5dd0b82e24a568087d2d8a17b3f33ce4d 100644 (file)
@@ -582,14 +582,6 @@ bool read_blktrace(struct thread_data* td)
                td->o.max_bs[DDIR_TRIM] = rw_bs[DDIR_TRIM];
        }
 
-       /*
-        * We need to do direct/raw ios to the device, to avoid getting
-        * read-ahead in our way. But only do so if the minimum block size
-        * is a multiple of 4k, otherwise we don't know if it's safe to do so.
-        */
-       if (!fio_option_is_set(&td->o, odirect) && !(td_min_bs(td) & 4095))
-               td->o.odirect = 1;
-
        /*
         * If depth wasn't manually set, use probed depth
         */