ASoC: cros_ec_codec: Add endianness flag in i2s_rx_component_driver
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Wed, 4 May 2022 17:08:53 +0000 (18:08 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 9 May 2022 11:46:40 +0000 (12:46 +0100)
The endianness flag is used on the CODEC side to specify an
ambivalence to endian, typically because it is lost over the hardware
link. The i2s_rx component receives audio over an I2S DAI and as such
should have endianness applied.

A fixup is also required to use the width directly rather than relying
on the format in hw_params, now both little and big endian would be
supported.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220504170905.332415-27-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cros_ec_codec.c

index 9b92e1a0d1a3a7da735b98fa328c7ecd233a3f80..8b0a9c788a264b14eddada9c00ec4e7e11479ddc 100644 (file)
@@ -232,11 +232,11 @@ static int i2s_rx_hw_params(struct snd_pcm_substream *substream,
        if (params_rate(params) != 48000)
                return -EINVAL;
 
-       switch (params_format(params)) {
-       case SNDRV_PCM_FORMAT_S16_LE:
+       switch (params_width(params)) {
+       case 16:
                depth = EC_CODEC_I2S_RX_SAMPLE_DEPTH_16;
                break;
-       case SNDRV_PCM_FORMAT_S24_LE:
+       case 24:
                depth = EC_CODEC_I2S_RX_SAMPLE_DEPTH_24;
                break;
        default:
@@ -387,6 +387,7 @@ static const struct snd_soc_component_driver i2s_rx_component_driver = {
        .num_dapm_widgets       = ARRAY_SIZE(i2s_rx_dapm_widgets),
        .dapm_routes            = i2s_rx_dapm_routes,
        .num_dapm_routes        = ARRAY_SIZE(i2s_rx_dapm_routes),
+       .endianness             = 1,
 };
 
 static void *wov_map_shm(struct cros_ec_codec_priv *priv,