mm/mempolicy: prepare weighted interleave sysfs for memory hotplug

Previously, the weighted interleave sysfs structure was statically managed
during initialization.  This prevented new nodes from being recognized
when memory hotplug events occurred, limiting the ability to update or
extend sysfs entries dynamically at runtime.

To address this, this patch refactors the sysfs infrastructure and
encapsulates it within a new structure, `sysfs_wi_group`, which holds both
the kobject and an array of node attribute pointers.

By allocating this group structure globally, the per-node sysfs attributes
can be managed beyond initialization time, enabling external modules to
insert or remove node entries in response to events such as memory hotplug
or node online/offline transitions.

Instead of allocating all per-node sysfs attributes at once, the
initialization path now uses the existing sysfs_wi_node_add() and
sysfs_wi_node_delete() helpers.  This refactoring makes it possible to
modularly manage per-node sysfs entries and ensures the infrastructure is
ready for runtime extension.

Link: https://lkml.kernel.org/r/20250417072839.711-3-rakie.kim@sk.com
Signed-off-by: Rakie Kim <rakie.kim@sk.com>
Reviewed-by: Gregory Price <gourry@gourry.net>
Reviewed-by: Joshua Hahn <joshua.hahnjy@gmail.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Honggyu Kim <honggyu.kim@sk.com>
Cc: "Huang, Ying" <ying.huang@linux.alibaba.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Yunjeong Mun <yunjeong.mun@sk.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index b8c7cce611031f48cc5d293ba8c40644436830a3..c99bae7d821964f20ed71e3c4f98472d69aa4b89 100644 (file)
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -3427,6 +3427,13 @@ struct iw_node_attr {
        int nid;
 };
 
+struct sysfs_wi_group {
+       struct kobject wi_kobj;
+       struct iw_node_attr *nattrs[];
+};
+
+static struct sysfs_wi_group *wi_group;
+
 static ssize_t node_show(struct kobject *kobj, struct kobj_attribute *attr,
                         char *buf)
 {
@@ -3469,24 +3476,23 @@ static ssize_t node_store(struct kobject *kobj, struct kobj_attribute *attr,
        return count;
 }
 
-static struct iw_node_attr **node_attrs;
-
-static void sysfs_wi_node_delete(struct iw_node_attr *node_attr,
-                                struct kobject *parent)
+static void sysfs_wi_node_delete(int nid)
 {
-       if (!node_attr)
+       if (!wi_group->nattrs[nid])
                return;
-       sysfs_remove_file(parent, &node_attr->kobj_attr.attr);
-       kfree(node_attr->kobj_attr.attr.name);
-       kfree(node_attr);
+
+       sysfs_remove_file(&wi_group->wi_kobj,
+                         &wi_group->nattrs[nid]->kobj_attr.attr);
+       kfree(wi_group->nattrs[nid]->kobj_attr.attr.name);
+       kfree(wi_group->nattrs[nid]);
 }
 
-static void sysfs_wi_node_delete_all(struct kobject *wi_kobj)
+static void sysfs_wi_node_delete_all(void)
 {
        int nid;
 
        for (nid = 0; nid < nr_node_ids; nid++)
-               sysfs_wi_node_delete(node_attrs[nid], wi_kobj);
+               sysfs_wi_node_delete(nid);
 }
 
 static void iw_table_free(void)
@@ -3503,15 +3509,14 @@ static void iw_table_free(void)
        kfree(old);
 }
 
-static void wi_cleanup(struct kobject *wi_kobj) {
-       sysfs_wi_node_delete_all(wi_kobj);
+static void wi_cleanup(void) {
+       sysfs_wi_node_delete_all();
        iw_table_free();
-       kfree(node_attrs);
 }
 
 static void wi_kobj_release(struct kobject *wi_kobj)
 {
-       kfree(wi_kobj);
+       kfree(wi_group);
 }
 
 static const struct kobj_type wi_ktype = {
@@ -3519,7 +3524,7 @@ static const struct kobj_type wi_ktype = {
        .release = wi_kobj_release,
 };
 
-static int add_weight_node(int nid, struct kobject *wi_kobj)
+static int sysfs_wi_node_add(int nid)
 {
        struct iw_node_attr *node_attr;
        char *name;
@@ -3541,40 +3546,33 @@ static int add_weight_node(int nid, struct kobject *wi_kobj)
        node_attr->kobj_attr.store = node_store;
        node_attr->nid = nid;
 
-       if (sysfs_create_file(wi_kobj, &node_attr->kobj_attr.attr)) {
+       if (sysfs_create_file(&wi_group->wi_kobj, &node_attr->kobj_attr.attr)) {
                kfree(node_attr->kobj_attr.attr.name);
                kfree(node_attr);
                pr_err("failed to add attribute to weighted_interleave\n");
                return -ENOMEM;
        }
 
-       node_attrs[nid] = node_attr;
+       wi_group->nattrs[nid] = node_attr;
        return 0;
 }
 
-static int add_weighted_interleave_group(struct kobject *root_kobj)
+static int __init add_weighted_interleave_group(struct kobject *mempolicy_kobj)
 {
-       struct kobject *wi_kobj;
        int nid, err;
 
-       node_attrs = kcalloc(nr_node_ids, sizeof(struct iw_node_attr *),
-                            GFP_KERNEL);
-       if (!node_attrs)
-               return -ENOMEM;
-
-       wi_kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL);
-       if (!wi_kobj) {
-               kfree(node_attrs);
+       wi_group = kzalloc(struct_size(wi_group, nattrs, nr_node_ids),
+                          GFP_KERNEL);
+       if (!wi_group)
                return -ENOMEM;
-       }
 
-       err = kobject_init_and_add(wi_kobj, &wi_ktype, root_kobj,
+       err = kobject_init_and_add(&wi_group->wi_kobj, &wi_ktype, mempolicy_kobj,
                                   "weighted_interleave");
        if (err)
                goto err_put_kobj;
 
        for_each_node_state(nid, N_POSSIBLE) {
-               err = add_weight_node(nid, wi_kobj);
+               err = sysfs_wi_node_add(nid);
                if (err) {
                        pr_err("failed to add sysfs [node%d]\n", nid);
                        goto err_cleanup_kobj;
@@ -3584,10 +3582,10 @@ static int add_weighted_interleave_group(struct kobject *root_kobj)
        return 0;
 
 err_cleanup_kobj:
-       wi_cleanup(wi_kobj);
-       kobject_del(wi_kobj);
+       wi_cleanup();
+       kobject_del(&wi_group->wi_kobj);
 err_put_kobj:
-       kobject_put(wi_kobj);
+       kobject_put(&wi_group->wi_kobj);
        return err;
 }