ASoC: cs35l36: Fix the error handling of cs35l36_i2c_probe()
authorZheyu Ma <zheyuma97@gmail.com>
Tue, 10 May 2022 15:32:47 +0000 (23:32 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 11 May 2022 16:40:13 +0000 (17:40 +0100)
The driver should goto label 'err' when failing at regmap_read().

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20220510153251.1741210-3-zheyuma97@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l36.c

index cc5e80222916e5e4c82b8a70d3ac1fb8719bd8ad..920190daa4d1b44021f5a140c279a47128a0ba41 100644 (file)
@@ -1803,7 +1803,7 @@ static int cs35l36_i2c_probe(struct i2c_client *i2c_client)
        if (ret < 0) {
                dev_err(&i2c_client->dev, "Failed to read otp_id Register %d\n",
                        ret);
-               return ret;
+               goto err;
        }
 
        if ((l37_id_reg & CS35L36_OTP_REV_MASK) == CS35L36_OTP_REV_L37)