vdpa: Fix pointer math bug in vdpasim_get_config()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 6 Apr 2020 14:45:52 +0000 (17:45 +0300)
committerMichael S. Tsirkin <mst@redhat.com>
Mon, 10 Aug 2020 14:38:55 +0000 (10:38 -0400)
If "offset" is non-zero then we end up copying from beyond the end of
the config because of pointer math.  We can fix this by casting the
struct to a u8 pointer.

Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200406144552.GF68494@mwanda
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
drivers/vdpa/vdpa_sim/vdpa_sim.c

index 604d9d25ca47f42fd261362f1e2b365b08189377..62d6403271450e0aff12173bb2a324a4089ddd14 100644 (file)
@@ -558,7 +558,7 @@ static void vdpasim_get_config(struct vdpa_device *vdpa, unsigned int offset,
        struct vdpasim *vdpasim = vdpa_to_sim(vdpa);
 
        if (offset + len < sizeof(struct virtio_net_config))
-               memcpy(buf, &vdpasim->config + offset, len);
+               memcpy(buf, (u8 *)&vdpasim->config + offset, len);
 }
 
 static void vdpasim_set_config(struct vdpa_device *vdpa, unsigned int offset,