bus: mhi: host: pci_generic: Remove redundant assign resource usage
authorSubramanian Ananthanarayanan <quic_skananth@quicinc.com>
Wed, 16 Apr 2025 05:19:51 +0000 (10:49 +0530)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Wed, 14 May 2025 10:30:58 +0000 (11:30 +0100)
Avoid redundant usage of pci_assign_resource for BAR allocation. This is
already taken care by PCI framework. Invocation of this API leads to
unnecessary relocation of BAR space to a new memory address.

Signed-off-by: Subramanian Ananthanarayanan <quic_skananth@quicinc.com>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
Link: https://patch.msgid.link/20250416-remove_assin_resource-v1-1-e92dd361fa0a@quicinc.com
drivers/bus/mhi/host/pci_generic.c

index 03aa887952098661a488650053a357f883d1559b..7501abc835c7b65665fde696571ed45144bed38c 100644 (file)
@@ -996,10 +996,6 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl,
        struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
        int err;
 
-       err = pci_assign_resource(pdev, bar_num);
-       if (err)
-               return err;
-
        err = pcim_enable_device(pdev);
        if (err) {
                dev_err(&pdev->dev, "failed to enable pci device: %d\n", err);