net/mlx4_en: CHECKSUM_COMPLETE support for fragments
authorEric Dumazet <edumazet@google.com>
Tue, 27 Mar 2018 21:21:14 +0000 (14:21 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 1 Apr 2018 17:56:37 +0000 (13:56 -0400)
Refine the RX check summing handling to propagate the
hardware provided checksum so that we do not have to
compute it later in software.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Cc: Tariq Toukan <tariqt@mellanox.com>
Acked-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/en_rx.c

index 05787efef492b1c0c6ce540ef73647fad91ce282..5c613c6663da51a4ae792eeb4d8956b54655786b 100644 (file)
@@ -821,14 +821,12 @@ xdp_drop_no_cnt:
                skb_record_rx_queue(skb, cq_ring);
 
                if (likely(dev->features & NETIF_F_RXCSUM)) {
-                       if (cqe->status & cpu_to_be16(MLX4_CQE_STATUS_TCP |
-                                                     MLX4_CQE_STATUS_UDP)) {
+                       if ((cqe->status & cpu_to_be16(MLX4_CQE_STATUS_TCP |
+                                                      MLX4_CQE_STATUS_UDP)) &&
+                           (cqe->status & cpu_to_be16(MLX4_CQE_STATUS_IPOK)) &&
+                           cqe->checksum == cpu_to_be16(0xffff)) {
                                bool l2_tunnel;
 
-                               if (!((cqe->status & cpu_to_be16(MLX4_CQE_STATUS_IPOK)) &&
-                                     cqe->checksum == cpu_to_be16(0xffff)))
-                                       goto csum_none;
-
                                l2_tunnel = (dev->hw_enc_features & NETIF_F_RXCSUM) &&
                                        (cqe->vlan_my_qpn & cpu_to_be32(MLX4_CQE_L2_TUNNEL));
                                ip_summed = CHECKSUM_UNNECESSARY;