drm/msm/dpu: drop extra aspace checks in dpu_formats
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Tue, 3 Sep 2024 03:22:49 +0000 (06:22 +0300)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 21 Oct 2024 11:11:11 +0000 (14:11 +0300)
The DPU driver isn't expected to be used without an IOMMU. Thus the
aspace will be always present. Not to mention that mdp4/mdp5 drivers
call msm_framebuffer_iova() without such checks, as the whole
msm_framebuffer layer is expected to support both IOMMU and IOMMU-less
configurations.

Drop these useless if (aspace) checks.

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/612249/
Link: https://lore.kernel.org/r/20240903-dpu-mode-config-width-v6-6-617e1ecc4b7a@linaro.org
drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c

index 027eb5ecff08490fcd65db52d533e37ed269d7fc..8c2dc5b59bb01bfff4136552e03b6a7da5fe9019 100644 (file)
@@ -280,8 +280,7 @@ static int _dpu_format_populate_addrs_ubwc(
                return -EINVAL;
        }
 
-       if (aspace)
-               base_addr = msm_framebuffer_iova(fb, aspace, 0);
+       base_addr = msm_framebuffer_iova(fb, aspace, 0);
        if (!base_addr) {
                DRM_ERROR("failed to retrieve base addr\n");
                return -EFAULT;
@@ -376,9 +375,7 @@ static int _dpu_format_populate_addrs_linear(
 
        /* Populate addresses for simple formats here */
        for (i = 0; i < layout->num_planes; ++i) {
-               if (aspace)
-                       layout->plane_addr[i] =
-                               msm_framebuffer_iova(fb, aspace, i);
+               layout->plane_addr[i] = msm_framebuffer_iova(fb, aspace, i);
                if (!layout->plane_addr[i]) {
                        DRM_ERROR("failed to retrieve base addr\n");
                        return -EFAULT;