clk: renesas: rzv2h: Improve rzv2h_ddiv_set_rate()
authorTommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Mon, 17 Mar 2025 08:32:10 +0000 (09:32 +0100)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 14 Apr 2025 08:09:40 +0000 (10:09 +0200)
Remove duplicate code into rzv2h_ddiv_set_rate().

Reported-by: Pavel Machek <pavel@denx.de>
Closes: https://lore.kernel.org/cip-dev/Z9QBZo4GgtMjid0v@duo.ucw.cz/
Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/20250317083213.371614-3-tommaso.merciai.xr@bp.renesas.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/clk/renesas/rzv2h-cpg.c

index b8bed0c1d9186e556592ec1eff7d90f332b6f8b8..1c09b92981ff492e1064e4c1e85bb6f0275909c3 100644 (file)
@@ -329,12 +329,6 @@ static int rzv2h_ddiv_set_rate(struct clk_hw *hw, unsigned long rate,
        writel(val, divider->reg);
 
        ret = rzv2h_cpg_wait_ddiv_clk_update_done(priv->base, ddiv->mon);
-       if (ret)
-               goto ddiv_timeout;
-
-       spin_unlock_irqrestore(divider->lock, flags);
-
-       return 0;
 
 ddiv_timeout:
        spin_unlock_irqrestore(divider->lock, flags);