soc: tegra: fuse: speedo-tegra124: Remove some set but unused variables
authorLee Jones <lee.jones@linaro.org>
Tue, 3 Nov 2020 15:28:26 +0000 (15:28 +0000)
committerThierry Reding <treding@nvidia.com>
Tue, 10 Nov 2020 19:40:49 +0000 (20:40 +0100)
Fixes the following W=1 kernel build warning(s):

 drivers/soc/tegra/fuse/speedo-tegra124.c: In function ‘tegra124_init_speedo_data’:
 drivers/soc/tegra/fuse/speedo-tegra124.c:105:38: warning: variable ‘soc_iddq_value’ set but not used [-Wunused-but-set-variable]
 drivers/soc/tegra/fuse/speedo-tegra124.c:105:22: warning: variable ‘gpu_iddq_value’ set but not used [-Wunused-but-set-variable]
 drivers/soc/tegra/fuse/speedo-tegra124.c:105:6: warning: variable ‘cpu_iddq_value’ set but not used [-Wunused-but-set-variable]

Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
[treding@nvidia.com: remove unnecessary reads altogether]
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/soc/tegra/fuse/speedo-tegra124.c

index bdbf76bb184fae68ae79ce3b5c305173af9c43a0..5b1ee28e4272fc8fb080170744ce9856aadc9d8d 100644 (file)
@@ -101,8 +101,7 @@ static void __init rev_sku_to_speedo_ids(struct tegra_sku_info *sku_info,
 
 void __init tegra124_init_speedo_data(struct tegra_sku_info *sku_info)
 {
-       int i, threshold, cpu_speedo_0_value, soc_speedo_0_value;
-       int cpu_iddq_value, gpu_iddq_value, soc_iddq_value;
+       int i, threshold, soc_speedo_0_value;
 
        BUILD_BUG_ON(ARRAY_SIZE(cpu_process_speedos) !=
                        THRESHOLD_INDEX_COUNT);
@@ -111,25 +110,17 @@ void __init tegra124_init_speedo_data(struct tegra_sku_info *sku_info)
        BUILD_BUG_ON(ARRAY_SIZE(soc_process_speedos) !=
                        THRESHOLD_INDEX_COUNT);
 
-       cpu_speedo_0_value = tegra_fuse_read_early(FUSE_CPU_SPEEDO_0);
-
-       /* GPU Speedo is stored in CPU_SPEEDO_2 */
-       sku_info->gpu_speedo_value = tegra_fuse_read_early(FUSE_CPU_SPEEDO_2);
-
-       soc_speedo_0_value = tegra_fuse_read_early(FUSE_SOC_SPEEDO_0);
-
-       cpu_iddq_value = tegra_fuse_read_early(FUSE_CPU_IDDQ);
-       soc_iddq_value = tegra_fuse_read_early(FUSE_SOC_IDDQ);
-       gpu_iddq_value = tegra_fuse_read_early(FUSE_GPU_IDDQ);
-
-       sku_info->cpu_speedo_value = cpu_speedo_0_value;
-
+       sku_info->cpu_speedo_value = tegra_fuse_read_early(FUSE_CPU_SPEEDO_0);
        if (sku_info->cpu_speedo_value == 0) {
                pr_warn("Tegra Warning: Speedo value not fused.\n");
                WARN_ON(1);
                return;
        }
 
+       /* GPU Speedo is stored in CPU_SPEEDO_2 */
+       sku_info->gpu_speedo_value = tegra_fuse_read_early(FUSE_CPU_SPEEDO_2);
+       soc_speedo_0_value = tegra_fuse_read_early(FUSE_SOC_SPEEDO_0);
+
        rev_sku_to_speedo_ids(sku_info, &threshold);
 
        sku_info->cpu_iddq_value = tegra_fuse_read_early(FUSE_CPU_IDDQ);