bus: mhi: core: Update debug messages to use client device

Debug messages dealing with client devices use the generic MHI
controller or parent device along with a channel number. It would
be better to instead use the client device directly and enable
better log messages for channel updates.

Suggested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/1617311778-1254-5-git-send-email-bbhatt@codeaurora.org
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
index 16bf8ec4e289139a3ab59e8fd73c4c31daf046df..ef778389476f60ddd2e59d050b3f0d7d730fffee 100644 (file)
--- a/drivers/bus/mhi/core/main.c
+++ b/drivers/bus/mhi/core/main.c
@@ -1246,7 +1246,7 @@ static int mhi_update_channel_state(struct mhi_controller *mhi_cntrl,
                                    struct mhi_chan *mhi_chan,
                                    enum mhi_ch_state_type to_state)
 {
-       struct device *dev = &mhi_cntrl->mhi_dev->dev;
+       struct device *dev = &mhi_chan->mhi_dev->dev;
        enum mhi_cmd_type cmd = MHI_CMD_NOP;
        int ret;
 
@@ -1324,7 +1324,7 @@ static void __mhi_unprepare_channel(struct mhi_controller *mhi_cntrl,
                                    struct mhi_chan *mhi_chan)
 {
        int ret;
-       struct device *dev = &mhi_cntrl->mhi_dev->dev;
+       struct device *dev = &mhi_chan->mhi_dev->dev;
 
        mutex_lock(&mhi_chan->mutex);
 
@@ -1348,13 +1348,11 @@ int mhi_prepare_channel(struct mhi_controller *mhi_cntrl,
                        struct mhi_chan *mhi_chan)
 {
        int ret = 0;
-       struct device *dev = &mhi_cntrl->mhi_dev->dev;
+       struct device *dev = &mhi_chan->mhi_dev->dev;
 
        if (!(BIT(mhi_cntrl->ee) & mhi_chan->ee_mask)) {
-               dev_err(dev,
-                       "Current EE: %s Required EE Mask: 0x%x for chan: %s\n",
-                       TO_MHI_EXEC_STR(mhi_cntrl->ee), mhi_chan->ee_mask,
-                       mhi_chan->name);
+               dev_err(dev, "Current EE: %s Required EE Mask: 0x%x\n",
+                       TO_MHI_EXEC_STR(mhi_cntrl->ee), mhi_chan->ee_mask);
                return -ENOTCONN;
        }