drm/i915/error: Fixup inactive/active counting
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 5 Jun 2018 16:06:23 +0000 (17:06 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 5 Jun 2018 18:23:33 +0000 (19:23 +0100)
The inactive counter was over the active list, and vice versa.
Fortuitously this should not cause a problem in practice as they shared
the same array and clamped the number of entries they would write.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Matthew Auld <matthew.william.auld@gmail.com>
Reviewed-by: Matthew Auld <matthew.william.auld@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180605160623.30163-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_gpu_error.c

index 47721437a4c58d17b68813c0b9087ff3dda00922..6702776303bfd0ad0c4ea963a768681baeb81660 100644 (file)
@@ -1570,11 +1570,11 @@ static void capture_pinned_buffers(struct i915_gpu_state *error)
        int count_inactive, count_active;
 
        count_inactive = 0;
-       list_for_each_entry(vma, &vm->active_list, vm_link)
+       list_for_each_entry(vma, &vm->inactive_list, vm_link)
                count_inactive++;
 
        count_active = 0;
-       list_for_each_entry(vma, &vm->inactive_list, vm_link)
+       list_for_each_entry(vma, &vm->active_list, vm_link)
                count_active++;
 
        bo = NULL;