bcachefs: Ensure we're RW before journalling

Reported-by: syzbot+c60cd352aedb109528bf@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

diff --git a/fs/bcachefs/recovery.c b/fs/bcachefs/recovery.c
index 63f990f5c63a17e397401d9a1320d7bdf99db704..cf513fc79ce4809b368adfd90cddbf6a510642c3 100644 (file)
--- a/fs/bcachefs/recovery.c
+++ b/fs/bcachefs/recovery.c
@@ -811,9 +811,11 @@ use_clean:
        clear_bit(BCH_FS_fsck_running, &c->flags);
 
        /* fsync if we fixed errors */
-       if (test_bit(BCH_FS_errors_fixed, &c->flags)) {
+       if (test_bit(BCH_FS_errors_fixed, &c->flags) &&
+           bch2_write_ref_tryget(c, BCH_WRITE_REF_fsync)) {
                bch2_journal_flush_all_pins(&c->journal);
                bch2_journal_meta(&c->journal);
+               bch2_write_ref_put(c, BCH_WRITE_REF_fsync);
        }
 
        /* If we fixed errors, verify that fs is actually clean now: */