crypto: iaa - Do not clobber req->base.data
authorHerbert Xu <herbert@gondor.apana.org.au>
Mon, 24 Mar 2025 04:04:18 +0000 (12:04 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Mon, 7 Apr 2025 05:22:25 +0000 (13:22 +0800)
The req->base.data field is for the user and must not be touched by
the driver, unless you save it first.

The iaa driver doesn't seem to be using the req->base.data value
so just remove the assignment.

Fixes: 09646c98d0bf ("crypto: iaa - Add irq support for the crypto async interface")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/intel/iaa/iaa_crypto_main.c

index 4240a2e3d375ac10d80ee5ad49b6dca07401542b..773aab8a8830bf07d26f4bc70ed7d39f12f5ebd7 100644 (file)
@@ -1185,8 +1185,7 @@ static int iaa_compress(struct crypto_tfm *tfm,   struct acomp_req *req,
                        " src_addr %llx, dst_addr %llx\n", __func__,
                        active_compression_mode->name,
                        src_addr, dst_addr);
-       } else if (ctx->async_mode)
-               req->base.data = idxd_desc;
+       }
 
        dev_dbg(dev, "%s: compression mode %s,"
                " desc->src1_addr %llx, desc->src1_size %d,"
@@ -1423,8 +1422,7 @@ static int iaa_decompress(struct crypto_tfm *tfm, struct acomp_req *req,
                        " src_addr %llx, dst_addr %llx\n", __func__,
                        active_compression_mode->name,
                        src_addr, dst_addr);
-       } else if (ctx->async_mode && !disable_async)
-               req->base.data = idxd_desc;
+       }
 
        dev_dbg(dev, "%s: decompression mode %s,"
                " desc->src1_addr %llx, desc->src1_size %d,"