fhandle: raise FILEID_IS_DIR in handle_type
authorChristian Brauner <brauner@kernel.org>
Tue, 24 Jun 2025 08:29:04 +0000 (10:29 +0200)
committerChristian Brauner <brauner@kernel.org>
Tue, 24 Jun 2025 11:00:09 +0000 (13:00 +0200)
Currently FILEID_IS_DIR is raised in fh_flags which is wrong.
Raise it in handle->handle_type were it's supposed to be.

Link: https://lore.kernel.org/20250624-work-pidfs-fhandle-v2-1-d02a04858fe3@kernel.org
Fixes: c374196b2b9f ("fs: name_to_handle_at() support for "explicit connectable" file handles")
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Cc: stable@kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/fhandle.c

index 3e092ae6d142aedf52885202815d6022455b93bc..66ff60591d17b29200ec9d0ac74daeb013d4db52 100644 (file)
@@ -88,7 +88,7 @@ static long do_sys_name_to_handle(const struct path *path,
                if (fh_flags & EXPORT_FH_CONNECTABLE) {
                        handle->handle_type |= FILEID_IS_CONNECTABLE;
                        if (d_is_dir(path->dentry))
-                               fh_flags |= FILEID_IS_DIR;
+                               handle->handle_type |= FILEID_IS_DIR;
                }
                retval = 0;
        }