perf script: Use thread__find_symbol() instead of ad-hoc equivalent
authorArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 24 Apr 2018 14:32:30 +0000 (11:32 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 26 Apr 2018 16:47:08 +0000 (13:47 -0300)
In dc323ce8e72d ("perf script: Enable printing of branch stack") it
first tries to find the map for an address, then the symbol in the DSO
backing that map, for that address, well, this is what
thread__find_symbol() does, so just use it and make the code shorter.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-03nx3aod955yqnf9l06im28j@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-script.c

index 5ec1c73bbfaf6bb0a67600407d176e6e39c7f8fe..ffd02faee87b1702f5227d10b1dae80538e47700 100644 (file)
@@ -764,13 +764,8 @@ static int perf_sample__fprintf_brstacksym(struct perf_sample *sample,
                from = br->entries[i].from;
                to   = br->entries[i].to;
 
-               thread__find_map(thread, sample->cpumode, from, &alf);
-               if (alf.map)
-                       alf.sym = map__find_symbol(alf.map, alf.addr);
-
-               thread__find_map(thread, sample->cpumode, to, &alt);
-               if (alt.map)
-                       alt.sym = map__find_symbol(alt.map, alt.addr);
+               thread__find_symbol(thread, sample->cpumode, from, &alf);
+               thread__find_symbol(thread, sample->cpumode, to, &alt);
 
                printed += symbol__fprintf_symname_offs(alf.sym, &alf, fp);
                if (PRINT_FIELD(DSO)) {