drm/msm/dp: Inline dp_display_is_sink_count_zero()
authorStephen Boyd <swboyd@chromium.org>
Wed, 6 Sep 2023 18:12:25 +0000 (11:12 -0700)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 9 Oct 2023 09:17:47 +0000 (12:17 +0300)
This function is basically a one-liner when you ignore the debug
logging. Just inline the function and drop the log to simplify the code.

Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Vinod Polimera <quic_vpolimer@quicinc.com>
Cc: Kuogee Hsieh <quic_khsieh@quicinc.com>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/556066/
Link: https://lore.kernel.org/r/20230906181226.2198441-2-swboyd@chromium.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/dp/dp_display.c

index 96bbf6fec2f1270ba46279d9c25673bb2a54a1ca..2a5f1ab9a65b08aa7ffcc4f00e9954ab2c622ab6 100644 (file)
@@ -341,14 +341,6 @@ static const struct component_ops dp_display_comp_ops = {
        .unbind = dp_display_unbind,
 };
 
-static bool dp_display_is_sink_count_zero(struct dp_display_private *dp)
-{
-       drm_dbg_dp(dp->drm_dev, "present=%#x sink_count=%d\n",
-                       dp->panel->dpcd[DP_DOWNSTREAMPORT_PRESENT],
-               dp->link->sink_count);
-       return drm_dp_is_branch(dp->panel->dpcd) && dp->link->sink_count == 0;
-}
-
 static void dp_display_send_hpd_event(struct msm_dp *dp_display)
 {
        struct dp_display_private *dp;
@@ -507,7 +499,7 @@ static int dp_display_handle_port_ststus_changed(struct dp_display_private *dp)
 {
        int rc = 0;
 
-       if (dp_display_is_sink_count_zero(dp)) {
+       if (drm_dp_is_branch(dp->panel->dpcd) && dp->link->sink_count == 0) {
                drm_dbg_dp(dp->drm_dev, "sink count is zero, nothing to do\n");
                if (dp->hpd_state != ST_DISCONNECTED) {
                        dp->hpd_state = ST_DISCONNECT_PENDING;