mfd: aat2870: No need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Jul 2019 16:47:22 +0000 (18:47 +0200)
committerLee Jones <lee.jones@linaro.org>
Mon, 12 Aug 2019 06:27:40 +0000 (07:27 +0100)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/aat2870-core.c
include/linux/mfd/aat2870.h

index 9f58cb2d378942f0f78db6965ce2b504dc9b4f1f..78ee4b28fca2402733197fc9dac67dc16d69b774 100644 (file)
@@ -321,18 +321,9 @@ static const struct file_operations aat2870_reg_fops = {
 static void aat2870_init_debugfs(struct aat2870_data *aat2870)
 {
        aat2870->dentry_root = debugfs_create_dir("aat2870", NULL);
-       if (!aat2870->dentry_root) {
-               dev_warn(aat2870->dev,
-                        "Failed to create debugfs root directory\n");
-               return;
-       }
 
-       aat2870->dentry_reg = debugfs_create_file("regs", 0644,
-                                                 aat2870->dentry_root,
-                                                 aat2870, &aat2870_reg_fops);
-       if (!aat2870->dentry_reg)
-               dev_warn(aat2870->dev,
-                        "Failed to create debugfs register file\n");
+       debugfs_create_file("regs", 0644, aat2870->dentry_root, aat2870,
+                           &aat2870_reg_fops);
 }
 
 #else
index af7267c480ee73bb12561692fc9b8037e52504db..2445842d482dc77118191c0ee022a6c123f1294e 100644 (file)
@@ -136,7 +136,6 @@ struct aat2870_data {
 
        /* for debugfs */
        struct dentry *dentry_root;
-       struct dentry *dentry_reg;
 };
 
 struct aat2870_subdev_info {