i3c/master: cmd_v1: Fix the exit criteria for the daa procedure
authorBilly Tsai <billy_tsai@aspeedtech.com>
Wed, 2 Aug 2023 10:09:09 +0000 (18:09 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 10 Aug 2023 07:37:25 +0000 (09:37 +0200)
The exit criteria for the DAA should check if the data length is equal to
1, instead of checking if the response status is equal to 1.

Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Link: https://lore.kernel.org/r/20230802100909.2568215-1-billy_tsai@aspeedtech.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/i3c/master/mipi-i3c-hci/cmd_v1.c

index d97c3175e0e2784ed6f53111d5a8d4aa9f3e8334..6a781f89b0e4066beef10dcf641d242e97504600 100644 (file)
@@ -339,7 +339,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
                        break;
                }
                if (RESP_STATUS(xfer[0].response) == RESP_ERR_NACK &&
-                   RESP_STATUS(xfer[0].response) == 1) {
+                   RESP_DATA_LENGTH(xfer->response) == 1) {
                        ret = 0;  /* no more devices to be assigned */
                        break;
                }