blk-zoned: Document locking assumptions
authorBart Van Assche <bvanassche@acm.org>
Tue, 17 Dec 2024 21:03:08 +0000 (13:03 -0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 23 Dec 2024 15:17:23 +0000 (08:17 -0700)
Document which functions expect that their callers must hold a lock.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20241217210310.645966-3-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-zoned.c

index 1575b887fa38dbacb09c3ad48223618f2b9b9415..954724a2e3c650bfa16af91fe2d52e2418a14fa8 100644 (file)
@@ -459,6 +459,8 @@ static inline void disk_put_zone_wplug(struct blk_zone_wplug *zwplug)
 static inline bool disk_should_remove_zone_wplug(struct gendisk *disk,
                                                 struct blk_zone_wplug *zwplug)
 {
+       lockdep_assert_held(&zwplug->lock);
+
        /* If the zone write plug was already removed, we are done. */
        if (zwplug->flags & BLK_ZONE_WPLUG_UNHASHED)
                return false;
@@ -913,6 +915,8 @@ static bool blk_zone_wplug_prepare_bio(struct blk_zone_wplug *zwplug,
 {
        struct gendisk *disk = bio->bi_bdev->bd_disk;
 
+       lockdep_assert_held(&zwplug->lock);
+
        /*
         * If we lost track of the zone write pointer due to a write error,
         * the user must either execute a report zones, reset the zone or finish