ASoC: uniphier: aio-core: Make some read-only arrays static const
authorColin Ian King <colin.i.king@gmail.com>
Fri, 2 Dec 2022 16:41:56 +0000 (16:41 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 5 Dec 2022 14:05:40 +0000 (14:05 +0000)
Don't populate the read-only arrays slotsel_2ch, slotsel_multi, v_pll
and v_div on the stack but instead make them static const. Also makes
the object code a little smaller.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20221202164156.1812971-1-colin.i.king@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/uniphier/aio-core.c

index b8195778953e1eab2fb7fb77ec4b61ff1d6aaaa2..0eba607581341e86b54bd74e58dfdb289f7a70cf 100644 (file)
@@ -277,17 +277,18 @@ void aio_port_reset(struct uniphier_aio_sub *sub)
 static int aio_port_set_ch(struct uniphier_aio_sub *sub)
 {
        struct regmap *r = sub->aio->chip->regmap;
-       u32 slotsel_2ch[] = {
+       static const u32 slotsel_2ch[] = {
                0, 0, 0, 0, 0,
        };
-       u32 slotsel_multi[] = {
+       static const u32 slotsel_multi[] = {
                OPORTMXTYSLOTCTR_SLOTSEL_SLOT0,
                OPORTMXTYSLOTCTR_SLOTSEL_SLOT1,
                OPORTMXTYSLOTCTR_SLOTSEL_SLOT2,
                OPORTMXTYSLOTCTR_SLOTSEL_SLOT3,
                OPORTMXTYSLOTCTR_SLOTSEL_SLOT4,
        };
-       u32 mode, *slotsel;
+       u32 mode;
+       const u32 *slotsel;
        int i;
 
        switch (params_channels(&sub->params)) {
@@ -515,13 +516,13 @@ static int aio_port_set_clk(struct uniphier_aio_sub *sub)
        struct uniphier_aio_chip *chip = sub->aio->chip;
        struct device *dev = &sub->aio->chip->pdev->dev;
        struct regmap *r = sub->aio->chip->regmap;
-       u32 v_pll[] = {
+       static const u32 v_pll[] = {
                OPORTMXCTR2_ACLKSEL_A1, OPORTMXCTR2_ACLKSEL_F1,
                OPORTMXCTR2_ACLKSEL_A2, OPORTMXCTR2_ACLKSEL_F2,
                OPORTMXCTR2_ACLKSEL_A2PLL,
                OPORTMXCTR2_ACLKSEL_RX1,
        };
-       u32 v_div[] = {
+       static const u32 v_div[] = {
                OPORTMXCTR2_DACCKSEL_1_2, OPORTMXCTR2_DACCKSEL_1_3,
                OPORTMXCTR2_DACCKSEL_1_1, OPORTMXCTR2_DACCKSEL_2_3,
        };