projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b10b627
)
ext4: reject the 'commit' option on ext2 filesystems
author
Eric Biggers
<ebiggers@google.com>
Tue, 10 May 2022 18:32:32 +0000
(11:32 -0700)
committer
Theodore Ts'o
<tytso@mit.edu>
Wed, 18 May 2022 15:24:22 +0000
(11:24 -0400)
The 'commit' option is only applicable for ext3 and ext4 filesystems,
and has never been accepted by the ext2 filesystem driver, so the ext4
driver shouldn't allow it on ext2 filesystems.
This fixes a failure in xfstest ext4/053.
Fixes:
8dc0aa8cf0f7
("ext4: check incompatible mount options while mounting ext2/3")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Ritesh Harjani <ritesh.list@gmail.com>
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Link:
https://lore.kernel.org/r/20220510183232.172615-1-ebiggers@kernel.org
fs/ext4/super.c
patch
|
blob
|
blame
|
history
diff --git
a/fs/ext4/super.c
b/fs/ext4/super.c
index 4b0ea8df1f5cc760cb8121dda2681d30876ea7ff..3f59efd3aa3e27541be822d7ea5b44d2086dc108 100644
(file)
--- a/
fs/ext4/super.c
+++ b/
fs/ext4/super.c
@@
-1915,6
+1915,7
@@
static const struct mount_opts {
MOPT_EXT4_ONLY | MOPT_CLEAR},
{Opt_warn_on_error, EXT4_MOUNT_WARN_ON_ERROR, MOPT_SET},
{Opt_nowarn_on_error, EXT4_MOUNT_WARN_ON_ERROR, MOPT_CLEAR},
+ {Opt_commit, 0, MOPT_NO_EXT2},
{Opt_nojournal_checksum, EXT4_MOUNT_JOURNAL_CHECKSUM,
MOPT_EXT4_ONLY | MOPT_CLEAR},
{Opt_journal_checksum, EXT4_MOUNT_JOURNAL_CHECKSUM,