mailbox: Propagate correct error return value
authorPeng Fan <peng.fan@nxp.com>
Fri, 11 Apr 2025 13:14:11 +0000 (21:14 +0800)
committerJassi Brar <jassisinghbrar@gmail.com>
Mon, 26 May 2025 21:23:39 +0000 (16:23 -0500)
In case of_property_match_string fails, it makes more sense
to return its error value to caller, not force the value to
ERR_PTR(-EINVAL).

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
drivers/mailbox/mailbox.c

index 3ecf92a580fef031d8add5e4c2e4df494a34010a..3a58dc56f015b0bf0ebc7551713af38c16439e11 100644 (file)
@@ -458,7 +458,7 @@ struct mbox_chan *mbox_request_channel_byname(struct mbox_client *cl,
        if (index < 0) {
                dev_err(cl->dev, "%s() could not locate channel named \"%s\"\n",
                        __func__, name);
-               return ERR_PTR(-EINVAL);
+               return ERR_PTR(index);
        }
        return mbox_request_channel(cl, index);
 }