r8169: disable detection of bogus xid's 308/388
authorHeiner Kallweit <hkallweit1@gmail.com>
Wed, 10 Feb 2021 21:45:51 +0000 (22:45 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Feb 2021 22:30:22 +0000 (14:30 -0800)
Several years ago these two entries have been added, but it's not clear
why. There's no trace that there has ever been such a chip version, and
not even the r8101 vendor driver knows these id's. So let's disable
detection, and if nobody complains remove them completely later.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169_main.c

index 74b01cb1f5bf3fed1827469c3a10ab557b9fb415..6cc54c263d8bf146d133e51817d5a42df226104b 100644 (file)
@@ -2036,9 +2036,12 @@ static enum mac_version rtl8169_get_mac_version(u16 xid, bool gmii)
                { 0x7c8, 0x348, RTL_GIGA_MAC_VER_09 },
                { 0x7c8, 0x248, RTL_GIGA_MAC_VER_09 },
                { 0x7c8, 0x340, RTL_GIGA_MAC_VER_16 },
-               /* FIXME: where did these entries come from ? -- FR */
-               { 0xfc8, 0x388, RTL_GIGA_MAC_VER_13 },
-               { 0xfc8, 0x308, RTL_GIGA_MAC_VER_13 },
+               /* FIXME: where did these entries come from ? -- FR
+                * Not even r8101 vendor driver knows these id's,
+                * so let's disable detection for now. -- HK
+                * { 0xfc8, 0x388,      RTL_GIGA_MAC_VER_13 },
+                * { 0xfc8, 0x308,      RTL_GIGA_MAC_VER_13 },
+                */
 
                /* 8110 family. */
                { 0xfc8, 0x980, RTL_GIGA_MAC_VER_06 },