scsi: bnx2fc: Remove redundant assignment to variable 'i'

The variable 'i' is being assigned a value that is never read, the
following code path via the label ofld_err never refers to the
variable. The assignment is redundant and can be removed.

Cleans up clang scan warning:
drivers/scsi/bnx2fc/bnx2fc_tgt.c:132:5: warning: Value stored to 'i'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20240415104311.484890-1-colin.i.king@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/bnx2fc/bnx2fc_tgt.c b/drivers/scsi/bnx2fc/bnx2fc_tgt.c
index 2c246e80c1c4d614fafb7183ecd8c5515bc9dd13..253e25d4c489aea2a56d606eb6d8317c820e8ac4 100644 (file)
--- a/drivers/scsi/bnx2fc/bnx2fc_tgt.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_tgt.c
@@ -128,10 +128,8 @@ retry_ofld:
                        BNX2FC_TGT_DBG(tgt, "ctx_alloc_failure, "
                                "retry ofld..%d\n", i++);
                        msleep_interruptible(1000);
-                       if (i > 3) {
-                               i = 0;
+                       if (i > 3)
                                goto ofld_err;
-                       }
                        goto retry_ofld;
                }
                goto ofld_err;