uio: uio_pruss: Fix potential NULL pointer dereference
authorEmil Goode <emilgoode@gmail.com>
Thu, 6 Jun 2013 13:55:28 +0000 (15:55 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Jun 2013 19:54:09 +0000 (12:54 -0700)
In function pruss_probe we free gdev and try to use
it on the next line. I have moved the dereference to
above the kfree of gdev.

Signed-off-by: Emil Goode <emilgoode@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/uio/uio_pruss.c

index 6e2ab007fe9c03fc7768bf84144155f73e1bd871..21f7a72301e43536867b1353cc79541652e5b05b 100644 (file)
@@ -136,9 +136,9 @@ static int pruss_probe(struct platform_device *dev)
        gdev->pruss_clk = clk_get(&dev->dev, "pruss");
        if (IS_ERR(gdev->pruss_clk)) {
                dev_err(&dev->dev, "Failed to get clock\n");
+               ret = PTR_ERR(gdev->pruss_clk);
                kfree(gdev->info);
                kfree(gdev);
-               ret = PTR_ERR(gdev->pruss_clk);
                return ret;
        } else {
                clk_enable(gdev->pruss_clk);