powerpc/pseries: use kfree_sensitive() in plpks_gen_password()
authorMinjie Du <duminjie@vivo.com>
Mon, 17 Jul 2023 09:26:48 +0000 (17:26 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 20 Oct 2023 12:22:17 +0000 (23:22 +1100)
password might contain private information, so better use
kfree_sensitive to free it.
In plpks_gen_password() use kfree_sensitive().

Signed-off-by: Minjie Du <duminjie@vivo.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230717092648.9752-1-duminjie@vivo.com
arch/powerpc/platforms/pseries/plpks.c

index 2d40304eb6c164f5a6ebc94784849953eb3b1432..febe18f251d0cfb360a6330e4d0932e6941ae75e 100644 (file)
@@ -150,7 +150,7 @@ static int plpks_gen_password(void)
                ospasswordlength = maxpwsize;
                ospassword = kzalloc(maxpwsize, GFP_KERNEL);
                if (!ospassword) {
-                       kfree(password);
+                       kfree_sensitive(password);
                        return -ENOMEM;
                }
                memcpy(ospassword, password, ospasswordlength);
@@ -163,7 +163,7 @@ static int plpks_gen_password(void)
                }
        }
 out:
-       kfree(password);
+       kfree_sensitive(password);
 
        return pseries_status_to_err(rc);
 }