soc: ti: knav_qmss: Constify struct knav_range_ops
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 23 Jun 2024 16:11:31 +0000 (18:11 +0200)
committerNishanth Menon <nm@ti.com>
Thu, 27 Jun 2024 22:45:28 +0000 (17:45 -0500)
'struct knav_range_ops' is not modified in these drivers.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig:
Before:
======
   text    data     bss     dec     hex filename
   7498    1193       0    8691    21f3 drivers/soc/ti/knav_qmss_acc.o

After:
=====
   text    data     bss     dec     hex filename
   7566    1145       0    8711    2207 drivers/soc/ti/knav_qmss_acc.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/a8b4b428f97fc584f38bf45100aa9da241aeb935.1719159074.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Nishanth Menon <nm@ti.com>
drivers/soc/ti/knav_qmss.h
drivers/soc/ti/knav_qmss_acc.c
drivers/soc/ti/knav_qmss_queue.c

index a01eda720bf6c8a10289e39cf754951ede06fedb..9325e8ce2e25c78b633f7c1caf0100f559684dfb 100644 (file)
@@ -333,7 +333,7 @@ struct knav_range_info {
        void                            *queue_base_inst;
        unsigned                        flags;
        struct list_head                list;
-       struct knav_range_ops           *ops;
+       const struct knav_range_ops     *ops;
        struct knav_acc_info            acc_info;
        struct knav_acc_channel *acc;
        unsigned                        num_irqs;
index 3d388646ed43c359f3d2dd0f8ef538f0818a7bd2..269b4e75ae4044bfc865cb04ba4c1dc97ad212cb 100644 (file)
@@ -450,7 +450,7 @@ static int knav_acc_free_range(struct knav_range_info *range)
        return 0;
 }
 
-static struct knav_range_ops knav_acc_range_ops = {
+static const struct knav_range_ops knav_acc_range_ops = {
        .set_notify     = knav_acc_set_notify,
        .init_queue     = knav_acc_init_queue,
        .open_queue     = knav_acc_open_queue,
index 06fb5505c22c793023c3ac201ded02a60a9529c6..f2055a76f84c2bdb71d962c0d9597fc65981befc 100644 (file)
@@ -411,7 +411,7 @@ static int knav_gp_close_queue(struct knav_range_info *range,
        return 0;
 }
 
-static struct knav_range_ops knav_gp_range_ops = {
+static const struct knav_range_ops knav_gp_range_ops = {
        .set_notify     = knav_gp_set_notify,
        .open_queue     = knav_gp_open_queue,
        .close_queue    = knav_gp_close_queue,