drm/lsdc: Request PCI BAR
authorPhilipp Stanner <pstanner@redhat.com>
Mon, 21 Oct 2024 09:11:16 +0000 (11:11 +0200)
committerSui Jingfeng <sui.jingfeng@linux.dev>
Mon, 25 Nov 2024 02:28:40 +0000 (10:28 +0800)
lsdc currently just ioremaps its PCI BAR with pcim_iomap(). Performing
a region regquest additionally can make the driver more robust.

Replace pcim_iomap() with the managed function pcim_iomap_region() which
performs the request and ioremaps the BAR.

Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Reviewed-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Link: https://patchwork.freedesktop.org/patch/msgid/20241021091116.14368-1-pstanner@redhat.com
drivers/gpu/drm/loongson/lsdc_drv.c

index 58d97403271c48f3dcaffb83fb61de7b4df805ea..a55aa1fe2c21e8c9f86e1e6af8dcbdcf6521ce1a 100644 (file)
@@ -232,9 +232,9 @@ lsdc_create_device(struct pci_dev *pdev,
        lsdc_gem_init(ddev);
 
        /* Bar 0 of the DC device contains the MMIO register's base address */
-       ldev->reg_base = pcim_iomap(pdev, 0, 0);
-       if (!ldev->reg_base)
-               return ERR_PTR(-ENODEV);
+       ldev->reg_base = pcim_iomap_region(pdev, 0, "lsdc");
+       if (IS_ERR(ldev->reg_base))
+               return ldev->reg_base;
 
        spin_lock_init(&ldev->reglock);