[POWERPC] EEH: Be careful when identifying "empty" slots.
authorLinas Vepstas <linas@austin.ibm.com>
Thu, 15 Nov 2007 18:57:27 +0000 (05:57 +1100)
committerPaul Mackerras <paulus@samba.org>
Mon, 3 Dec 2007 02:56:26 +0000 (13:56 +1100)
If an "empty" slot is failing, make sure its a permanent failure;
else process the error normally.

Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/platforms/pseries/eeh.c

index 42a30b6628a9b4b47acfcadd9d1d9b865298f625..aa14a8559edb99480cd65b63c15b27546b4ba50a 100644 (file)
@@ -546,7 +546,7 @@ int eeh_dn_check_failure(struct device_node *dn, struct pci_dev *dev)
 
        /* Note that config-io to empty slots may fail;
         * they are empty when they don't have children. */
-       if ((rets[0] == 5) && (dn->child == NULL)) {
+       if ((rets[0] == 5) && (rets[2] == 0) && (dn->child == NULL)) {
                false_positives++;
                pdn->eeh_false_positives ++;
                rc = 0;