selftests/bpf: Convert comma to semicolon
authorChen Ni <nichen@iscas.ac.cn>
Tue, 1 Apr 2025 06:15:46 +0000 (14:15 +0800)
committerAndrii Nakryiko <andrii@kernel.org>
Fri, 4 Apr 2025 15:53:57 +0000 (08:53 -0700)
Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Reviewed-by: Amery Hung <ameryhung@gmail.com>
Link: https://lore.kernel.org/bpf/20250401061546.1990156-1-nichen@iscas.ac.cn
tools/testing/selftests/bpf/test_kmods/bpf_testmod.c

index 3220f1d28697e6f22ff6da2ea80417f7f187f538..f38eaf0d35efa712ec288f06983c86b02c0d3e0e 100644 (file)
@@ -1340,7 +1340,7 @@ static int st_ops_gen_prologue_with_kfunc(struct bpf_insn *insn_buf, bool direct
        *insn++ = BPF_STX_MEM(BPF_DW, BPF_REG_6, BPF_REG_7, offsetof(struct st_ops_args, a));
        *insn++ = BPF_JMP_IMM(BPF_JA, 0, 0, 2);
        *insn++ = BPF_MOV64_REG(BPF_REG_1, BPF_REG_0);
-       *insn++ = BPF_CALL_KFUNC(0, bpf_cgroup_release_id),
+       *insn++ = BPF_CALL_KFUNC(0, bpf_cgroup_release_id);
        *insn++ = BPF_MOV64_REG(BPF_REG_1, BPF_REG_8);
        *insn++ = prog->insnsi[0];
 
@@ -1379,7 +1379,7 @@ static int st_ops_gen_epilogue_with_kfunc(struct bpf_insn *insn_buf, const struc
        *insn++ = BPF_STX_MEM(BPF_DW, BPF_REG_1, BPF_REG_6, offsetof(struct st_ops_args, a));
        *insn++ = BPF_JMP_IMM(BPF_JA, 0, 0, 2);
        *insn++ = BPF_MOV64_REG(BPF_REG_1, BPF_REG_0);
-       *insn++ = BPF_CALL_KFUNC(0, bpf_cgroup_release_id),
+       *insn++ = BPF_CALL_KFUNC(0, bpf_cgroup_release_id);
        *insn++ = BPF_MOV64_REG(BPF_REG_0, BPF_REG_6);
        *insn++ = BPF_ALU64_IMM(BPF_MUL, BPF_REG_0, 2);
        *insn++ = BPF_EXIT_INSN();