wifi: iwlwifi: mvm: don't call power_update_mac in fast suspend
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Mon, 28 Oct 2024 11:54:59 +0000 (13:54 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 7 Nov 2024 13:42:30 +0000 (14:42 +0100)
We don't have any interface anyway.
Trying to send a command after the D3_CONFIG command is also a really
bad idea.
No harm done since this function wouldn't send anything to the firmware
anyway.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20241028135215.2636b358c870.I36717b4cff98eaa79182e0f3b5404f71aeeaf2f9@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/d3.c

index 16a9738dcdc97e27c6a6b0559971037fe9d7cec7..84c2c87b017f65799801753b21fb70e549e78797 100644 (file)
@@ -3682,8 +3682,6 @@ void iwl_mvm_fast_suspend(struct iwl_mvm *mvm)
                IWL_ERR(mvm,
                        "fast suspend: couldn't send D3_CONFIG_CMD %d\n", ret);
 
-       WARN_ON(iwl_mvm_power_update_mac(mvm));
-
        ret = iwl_trans_d3_suspend(mvm->trans, false, false);
        if (ret)
                IWL_ERR(mvm, "fast suspend: trans_d3_suspend failed %d\n", ret);