i2c: designware: Fix RX FIFO depth define on Wangxun 10Gb NIC
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Tue, 13 Feb 2024 12:48:46 +0000 (14:48 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Tue, 27 Feb 2024 00:51:34 +0000 (01:51 +0100)
I believe RX FIFO depth define 0 is incorrect on Wangxun 10Gb NIC. It
must be at least 1 since code is able to read received data from the
DW_IC_DATA_CMD register.

For now this define is irrelevant since the txgbe_i2c_dw_xfer_quirk()
doesn't use the rx_fifo_depth member variable of struct dw_i2c_dev but
is needed when converting code into generic polling mode implementation.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Jiawen Wu <jiawenwu@trustnetic.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-designware-core.h

index 4d277ebcca928dd6fe59e247ca4f6ad7babf5e6e..bf8f140dc113bae1349d3c9fee60cd7bf4079573 100644 (file)
@@ -319,7 +319,7 @@ struct dw_i2c_dev {
 #define AMD_UCSI_INTR_EN                       0xd
 
 #define TXGBE_TX_FIFO_DEPTH                    4
-#define TXGBE_RX_FIFO_DEPTH                    0
+#define TXGBE_RX_FIFO_DEPTH                    1
 
 struct i2c_dw_semaphore_callbacks {
        int     (*probe)(struct dw_i2c_dev *dev);