regulator: pwm-regulator: Add validity checks in continuous .get_voltage
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Sat, 13 Jan 2024 22:46:26 +0000 (23:46 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 22 Jan 2024 15:31:22 +0000 (15:31 +0000)
Continuous regulators can be configured to operate only in a certain
duty cycle range (for example from 0..91%). Add a check to error out if
the duty cycle translates to an unsupported (or out of range) voltage.

Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Link: https://msgid.link/r/20240113224628.377993-2-martin.blumenstingl@googlemail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/pwm-regulator.c

index 698c420e0869bd464f1368305b16d26a18360fa4..226ca4c62673ffdb2fd1f61a28df62384c297816 100644 (file)
@@ -158,6 +158,9 @@ static int pwm_regulator_get_voltage(struct regulator_dev *rdev)
        pwm_get_state(drvdata->pwm, &pstate);
 
        voltage = pwm_get_relative_duty_cycle(&pstate, duty_unit);
+       if (voltage < min(max_uV_duty, min_uV_duty) ||
+           voltage > max(max_uV_duty, min_uV_duty))
+               return -ENOTRECOVERABLE;
 
        /*
         * The dutycycle for min_uV might be greater than the one for max_uV.