drm/msm/dp: stop passing panel to msm_dp_audio_get()
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sun, 15 Dec 2024 22:44:10 +0000 (00:44 +0200)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Sun, 22 Dec 2024 07:26:05 +0000 (09:26 +0200)
The dp_audio module doesn't make any use of the passed DP panel
instance. Drop the argument.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Tested-by: Stephen Boyd <swboyd@chromium.org> # sc7180-trogdor
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/629056/
Link: https://lore.kernel.org/r/20241216-fd-dp-audio-fixup-v4-5-f8d1961cf22f@linaro.org
drivers/gpu/drm/msm/dp/dp_audio.c
drivers/gpu/drm/msm/dp/dp_audio.h
drivers/gpu/drm/msm/dp/dp_display.c

index 9e402d71b9761f640f1a8733e10e09477ff675cb..a4b792624ccc444f8912eb967d722cb94f6d4087 100644 (file)
@@ -351,14 +351,13 @@ int msm_dp_register_audio_driver(struct device *dev,
 }
 
 struct msm_dp_audio *msm_dp_audio_get(struct platform_device *pdev,
-                       struct msm_dp_panel *panel,
                        struct msm_dp_catalog *catalog)
 {
        int rc = 0;
        struct msm_dp_audio_private *audio;
        struct msm_dp_audio *msm_dp_audio;
 
-       if (!pdev || !panel || !catalog) {
+       if (!pdev || !catalog) {
                DRM_ERROR("invalid input\n");
                rc = -EINVAL;
                goto error;
index 1c9efaaa40e5879e54c1ed4a3d04a39a85c9402f..beea34cbab77f31b33873297dc454a9cee446240 100644 (file)
@@ -8,7 +8,6 @@
 
 #include <linux/platform_device.h>
 
-#include "dp_panel.h"
 #include "dp_catalog.h"
 #include <sound/hdmi-codec.h>
 
@@ -28,14 +27,12 @@ struct msm_dp_audio {
  * Creates and instance of dp audio.
  *
  * @pdev: caller's platform device instance.
- * @panel: an instance of msm_dp_panel module.
  * @catalog: an instance of msm_dp_catalog module.
  *
  * Returns the error code in case of failure, otherwize
  * an instance of newly created msm_dp_module.
  */
 struct msm_dp_audio *msm_dp_audio_get(struct platform_device *pdev,
-                       struct msm_dp_panel *panel,
                        struct msm_dp_catalog *catalog);
 
 /**
index fe51a01a69db01e740fb248e012b8f04b2def024..d852e7a853348cb2602fba917925ae43c55fa1a1 100644 (file)
@@ -780,7 +780,7 @@ static int msm_dp_init_sub_modules(struct msm_dp_display_private *dp)
                goto error_ctrl;
        }
 
-       dp->audio = msm_dp_audio_get(dp->msm_dp_display.pdev, dp->panel, dp->catalog);
+       dp->audio = msm_dp_audio_get(dp->msm_dp_display.pdev, dp->catalog);
        if (IS_ERR(dp->audio)) {
                rc = PTR_ERR(dp->audio);
                pr_err("failed to initialize audio, rc = %d\n", rc);