net/smc: ignore loopback-ism when dumping SMC-D devices

Since loopback-ism is not a PCI device, the PCI information fed back by
smc_nl_handle_smcd_dev() does not apply to loopback-ism. So currently
ignore loopback-ism when dumping SMC-D devices. The netlink function of
loopback-ism will be refactored when SMC netlink interface is updated.

Link: https://lore.kernel.org/r/caab067b-f5c3-490f-9259-262624c236b4@linux.ibm.com/
Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
Reviewed-and-tested-by: Jan Karcher <jaka@linux.ibm.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/net/smc/smc_ism.c b/net/smc/smc_ism.c
index 36459a3c739da78fa49d87d08a66a92c52c62a50..188fd28423c2be1b54b5bf47cd7eae0f620e7839 100644 (file)
--- a/net/smc/smc_ism.c
+++ b/net/smc/smc_ism.c
@@ -322,6 +322,8 @@ static void smc_nl_prep_smcd_dev(struct smcd_dev_list *dev_list,
        list_for_each_entry(smcd, &dev_list->list, list) {
                if (num < snum)
                        goto next;
+               if (smc_ism_is_loopback(smcd))
+                       goto next;
                if (smc_nl_handle_smcd_dev(smcd, skb, cb))
                        goto errout;
 next:

diff --git a/net/smc/smc_ism.h b/net/smc/smc_ism.h
index 165cd013404bca6c67397d079ae8cf849dfcc6fe..322973527c61c2402a1a19092615fb7a4feb3fc1 100644 (file)
--- a/net/smc/smc_ism.h
+++ b/net/smc/smc_ism.h
@@ -84,4 +84,9 @@ static inline bool smc_ism_is_emulated(struct smcd_dev *smcd)
        return __smc_ism_is_emulated(chid);
 }
 
+static inline bool smc_ism_is_loopback(struct smcd_dev *smcd)
+{
+       return (smcd->ops->get_chid(smcd) == 0xFFFF);
+}
+
 #endif