media: aspeed: remove IRQF_SHARED flag
authorJae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Fri, 31 May 2019 22:15:42 +0000 (18:15 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 5 Jun 2019 19:40:39 +0000 (15:40 -0400)
Video Engine has a dedicated interrupt line so this driver doesn't
need to use IRQF_SHARED flag so remove it. Also, it'd be good for
following what Thomas recommended in the IRQF_ONESHOT support
patch like below:

"Note that for now IRQF_ONESHOT cannot be used with IRQF_SHARED to
avoid complex accounting mechanisms."

Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Reviewed-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/aspeed-video.c

index f7db8969c8f27b99445c03d5f49e4662194cdc9d..d1b5414095441e418f8e1aadec8312a8089731a6 100644 (file)
@@ -1601,8 +1601,7 @@ static int aspeed_video_init(struct aspeed_video *video)
        }
 
        rc = devm_request_threaded_irq(dev, irq, NULL, aspeed_video_irq,
-                                      IRQF_ONESHOT | IRQF_SHARED, DEVICE_NAME,
-                                      video);
+                                      IRQF_ONESHOT, DEVICE_NAME, video);
        if (rc < 0) {
                dev_err(dev, "Unable to request IRQ %d\n", irq);
                return rc;