io_uring: fix memory leak of uid in files registration
authorPavel Begunkov <asml.silence@gmail.com>
Fri, 25 Mar 2022 16:36:31 +0000 (16:36 +0000)
committerJens Axboe <axboe@kernel.dk>
Fri, 25 Mar 2022 22:07:06 +0000 (16:07 -0600)
When there are no files for __io_sqe_files_scm() to process in the
range, it'll free everything and return. However, it forgets to put uid.

Fixes: 08a451739a9b5 ("io_uring: allow sparse fixed file sets")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/accee442376f33ce8aaebb099d04967533efde92.1648226048.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index cc3a22d60fb4522e11ba6d65cf2f8c1339efa73b..39a9ff31dbc56cd850f686f949e5df290c10cfd5 100644 (file)
@@ -8845,6 +8845,7 @@ static int __io_sqe_files_scm(struct io_ring_ctx *ctx, int nr, int offset)
                        fput(fpl->fp[i]);
        } else {
                kfree_skb(skb);
+               free_uid(fpl->user);
                kfree(fpl);
        }