i2c: core: ACPI: Improve OpRegion read errors
authorHans de Goede <hdegoede@redhat.com>
Sun, 22 Apr 2018 17:57:59 +0000 (19:57 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Mon, 30 Apr 2018 08:53:26 +0000 (10:53 +0200)
When we get an error doing an ACPI SerialBus I2C OpRegion read log some
useful details, like the client address and which register is being
read.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/i2c-core-acpi.c

index a9126b3cda61bc95f6a9d1282821ab7552484534..3dc43a009f5d7b45af9cf27f745a37f94054d6d9 100644 (file)
@@ -446,7 +446,8 @@ static int acpi_gsb_i2c_read_bytes(struct i2c_client *client,
 
        ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs));
        if (ret < 0)
-               dev_err(&client->adapter->dev, "i2c read failed\n");
+               dev_err(&client->adapter->dev, "i2c read %d bytes from client@%#x starting at reg %#x failed, error: %d\n",
+                       data_len, client->addr, cmd, ret);
        else
                memcpy(data, buffer, data_len);