netdevsim: Change dummy reporter auto recover default

Health reporters should be registered with auto recover set to true.
Align dummy reporter behaviour with that, as in later patch the option to
set auto recover behaviour will be removed.

In addition, align netdevsim selftest to the new default value.

Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/netdevsim/health.c b/drivers/net/netdevsim/health.c
index ba8d9ad60feb3298f4b41ff3f0764f372facd519..9ff345d5524b4e4d257808666f57f84bc2daef20 100644 (file)
--- a/drivers/net/netdevsim/health.c
+++ b/drivers/net/netdevsim/health.c
@@ -278,7 +278,7 @@ int nsim_dev_health_init(struct nsim_dev *nsim_dev, struct devlink *devlink)
        health->dummy_reporter =
                devlink_health_reporter_create(devlink,
                                               &nsim_dev_dummy_reporter_ops,
-                                              0, false, health);
+                                              0, true, health);
        if (IS_ERR(health->dummy_reporter)) {
                err = PTR_ERR(health->dummy_reporter);
                goto err_empty_reporter_destroy;

diff --git a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh b/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
index 32cb2a159c70407327254f3cefa0d01fd55d1e15..9f97414445496cab0d95d3538ba1f0651191b21d 100755 (executable)
--- a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
+++ b/tools/testing/selftests/drivers/net/netdevsim/devlink.sh
@@ -377,6 +377,11 @@ dummy_reporter_test()
 {
        RET=0
 
+       check_reporter_info dummy healthy 0 0 0 true
+
+       devlink health set $DL_HANDLE reporter dummy auto_recover false
+       check_err $? "Failed to dummy reporter auto_recover option"
+
        check_reporter_info dummy healthy 0 0 0 false
 
        local BREAK_MSG="foo bar"