net: rswitch: Drop unused argument/return value
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Fri, 8 Dec 2023 04:10:22 +0000 (13:10 +0900)
committerDavid S. Miller <davem@davemloft.net>
Sun, 10 Dec 2023 19:31:41 +0000 (19:31 +0000)
Drop unused argument and return value of rswitch_tx_free() to
simplify the code.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/rswitch.c

index 89e7a6551c64e1c46e7a35d8f144dd95f004ac68..8c03c0e18003fae171935de9a9813a9b73f3e41e 100644 (file)
@@ -761,20 +761,19 @@ err:
        return 0;
 }
 
-static int rswitch_tx_free(struct net_device *ndev, bool free_txed_only)
+static void rswitch_tx_free(struct net_device *ndev)
 {
        struct rswitch_device *rdev = netdev_priv(ndev);
        struct rswitch_gwca_queue *gq = rdev->tx_queue;
        struct rswitch_ext_desc *desc;
        dma_addr_t dma_addr;
        struct sk_buff *skb;
-       int free_num = 0;
        int size;
 
        for (; rswitch_get_num_cur_queues(gq) > 0;
             gq->dirty = rswitch_next_queue_index(gq, false, 1)) {
                desc = &gq->tx_ring[gq->dirty];
-               if (free_txed_only && (desc->desc.die_dt & DT_MASK) != DT_FEMPTY)
+               if ((desc->desc.die_dt & DT_MASK) != DT_FEMPTY)
                        break;
 
                dma_rmb();
@@ -786,14 +785,11 @@ static int rswitch_tx_free(struct net_device *ndev, bool free_txed_only)
                                         size, DMA_TO_DEVICE);
                        dev_kfree_skb_any(gq->skbs[gq->dirty]);
                        gq->skbs[gq->dirty] = NULL;
-                       free_num++;
                }
                desc->desc.die_dt = DT_EEMPTY;
                rdev->ndev->stats.tx_packets++;
                rdev->ndev->stats.tx_bytes += size;
        }
-
-       return free_num;
 }
 
 static int rswitch_poll(struct napi_struct *napi, int budget)
@@ -808,7 +804,7 @@ static int rswitch_poll(struct napi_struct *napi, int budget)
        priv = rdev->priv;
 
 retry:
-       rswitch_tx_free(ndev, true);
+       rswitch_tx_free(ndev);
 
        if (rswitch_rx(ndev, &quota))
                goto out;