pwm: lpss: Remove ->free() callback
authorMika Westerberg <mika.westerberg@linux.intel.com>
Wed, 9 Dec 2015 14:05:59 +0000 (16:05 +0200)
committerThierry Reding <thierry.reding@gmail.com>
Wed, 16 Dec 2015 15:31:27 +0000 (16:31 +0100)
The LPSS PWM driver calls pwm_lpss_disable() when the PWM device is
released (for example unexported from sysfs). This in turn calls
pm_runtime_put() which makes runtime PM count to be unbalanced if the
device has not been enabled at this point.

This is easy to reproduce:

  # cd /sys/class/pwm/pwmchip0
  # echo 0 > export
  # echo 0 > unexport

The count is unbalanced and prevents the PWM device from being powered on
next time.

Fix this by removing ->free() callback. There are no resources to be
released anyway.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
drivers/pwm/pwm-lpss.c

index 25044104003b01a7e3879fe6b94e7e5e7d477681..3f61c50964d56d66462f2b5f779a4f546bd8b60e 100644 (file)
@@ -135,7 +135,6 @@ static void pwm_lpss_disable(struct pwm_chip *chip, struct pwm_device *pwm)
 }
 
 static const struct pwm_ops pwm_lpss_ops = {
-       .free = pwm_lpss_disable,
        .config = pwm_lpss_config,
        .enable = pwm_lpss_enable,
        .disable = pwm_lpss_disable,