platform/x86/amd/pmf: change amd_pmf_init_features() call sequence
authorShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Tue, 12 Dec 2023 01:46:58 +0000 (07:16 +0530)
committerHans de Goede <hdegoede@redhat.com>
Mon, 18 Dec 2023 11:47:46 +0000 (12:47 +0100)
To sideload pmf policy binaries, the Smart PC Solution Builder provides a
debugfs file called "update_policy"; that gets created under a new debugfs
directory called "pb" and this new directory has to be associated with
existing parent directory for PMF driver called "amd_pmf".

In the current code structure, amd_pmf_dbgfs_register() is called after
amd_pmf_init_features(). This will not help when the Smart PC builder
feature has to be assoicated to the parent directory.

Hence change the order of amd_pmf_dbgfs_register() and call it before
amd_pmf_init_features() so that when the Smart PC init happens, it has the
parent debugfs directory to get itself hooked.

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20231212014705.2017474-6-Shyam-sundar.S-k@amd.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/amd/pmf/core.c

index c10d40b336675a843cc68b59d081f982b7224b7b..feaa09f5b35a125c9c704a432f82c7672b7bc139 100644 (file)
@@ -431,9 +431,9 @@ static int amd_pmf_probe(struct platform_device *pdev)
 
        apmf_acpi_init(dev);
        platform_set_drvdata(pdev, dev);
+       amd_pmf_dbgfs_register(dev);
        amd_pmf_init_features(dev);
        apmf_install_handler(dev);
-       amd_pmf_dbgfs_register(dev);
 
        dev_info(dev->dev, "registered PMF device successfully\n");