cteontx2-pf: cn10k: Prevent harmless double shift bugs
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 17 Feb 2021 06:16:20 +0000 (09:16 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 17 Feb 2021 22:26:49 +0000 (14:26 -0800)
These defines are used with set_bit() and test_bit() which take a bit
number.  In other words, the code is doing:

if (BIT(BIT(1)) & pf->hw.cap_flag) {

This was done consistently so it did not cause a problem at runtime but
it's still worth fixing.

Fixes: facede8209ef ("octeontx2-pf: cn10k: Add mbox support for CN10K")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h

index f14d388efb511d2825dc5d88d52a13fe421fe68c..a518c2283f184154a129dc800619866a9c777c11 100644 (file)
@@ -210,9 +210,9 @@ struct otx2_hw {
        u64                     cgx_fec_uncorr_blks;
        u8                      cgx_links;  /* No. of CGX links present in HW */
        u8                      lbk_links;  /* No. of LBK links present in HW */
-#define HW_TSO                 BIT_ULL(0)
-#define CN10K_MBOX             BIT_ULL(1)
-#define CN10K_LMTST            BIT_ULL(2)
+#define HW_TSO                 0
+#define CN10K_MBOX             1
+#define CN10K_LMTST            2
        unsigned long           cap_flag;
 
 #define LMT_LINE_SIZE          128