nexthops: remove redundant assignment to variable err
authorColin Ian King <colin.king@canonical.com>
Thu, 22 Aug 2019 12:53:40 +0000 (13:53 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Aug 2019 19:14:05 +0000 (12:14 -0700)
Variable err is initialized to a value that is never read and it is
re-assigned later. The initialization is redundant and can be removed.

Addresses-Coverity: ("Unused Value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/nexthop.c

index 5fe5a3981d4316ad8d9dbf54f5d9017b89e24038..fc34fd1668d6ddd44a5cd4e47ad98c5decb2c1d5 100644 (file)
@@ -1151,7 +1151,7 @@ static int nh_create_ipv4(struct net *net, struct nexthop *nh,
                .fc_encap_type = cfg->nh_encap_type,
        };
        u32 tb_id = l3mdev_fib_table(cfg->dev);
-       int err = -EINVAL;
+       int err;
 
        err = fib_nh_init(net, fib_nh, &fib_cfg, 1, extack);
        if (err) {