octeontx2: Remove unnecessary ternary operators
authorRuan Jinjie <ruanjinjie@huawei.com>
Tue, 1 Aug 2023 11:26:38 +0000 (19:26 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 2 Aug 2023 19:08:27 +0000 (12:08 -0700)
There are a little ternary operators, the true or false judgement
of which is unnecessary in C language semantics. So remove it
to clean Code.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Sunil Goutham <sgoutham@marvell.com>
Link: https://lore.kernel.org/r/20230801112638.317149-1-ruanjinjie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/af/ptp.c
drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c

index 0ee420a489fc4980e6356210bcb7b3e0a71a0561..c55c2c441a1a71a635367f3535d24417d10f7f44 100644 (file)
@@ -61,12 +61,12 @@ static const struct pci_device_id ptp_id_table[];
 
 static bool is_ptp_dev_cnf10kb(struct ptp *ptp)
 {
-       return (ptp->pdev->subsystem_device == PCI_SUBSYS_DEVID_CNF10K_B_PTP) ? true : false;
+       return ptp->pdev->subsystem_device == PCI_SUBSYS_DEVID_CNF10K_B_PTP;
 }
 
 static bool is_ptp_dev_cn10k(struct ptp *ptp)
 {
-       return (ptp->pdev->device == PCI_DEVID_CN10K_PTP) ? true : false;
+       return ptp->pdev->device == PCI_DEVID_CN10K_PTP;
 }
 
 static bool cn10k_ptp_errata(struct ptp *ptp)
index 9551b422622a422576ab0012f48f50db13fa03aa..61f62a6ec6627cd006e34df8ac37feedc4dd8853 100644 (file)
@@ -2027,7 +2027,7 @@ u16 otx2_select_queue(struct net_device *netdev, struct sk_buff *skb,
 #endif
        int txq;
 
-       qos_enabled = (netdev->real_num_tx_queues > pf->hw.tx_queues) ? true : false;
+       qos_enabled = netdev->real_num_tx_queues > pf->hw.tx_queues;
        if (unlikely(qos_enabled)) {
                /* This smp_load_acquire() pairs with smp_store_release() in
                 * otx2_qos_root_add() called from htb offload root creation