perf test: Remove cpu-list BPF cgroup counter test
authorMichael Petlan <mpetlan@redhat.com>
Fri, 1 Nov 2024 10:28:12 +0000 (11:28 +0100)
committerNamhyung Kim <namhyung@kernel.org>
Tue, 5 Nov 2024 06:10:48 +0000 (22:10 -0800)
The cpu-list part of this testcase has proven itself to be unreliable.
Sometimes, we get "<not counted>" for system.slice when pinned to CPUs
0 and 1. In such case, the test fails.

Since we cannot simply guarantee that any system.slice load will run
on any arbitrary list of CPUs, except the whole set of all CPUs, let's
rather remove the cpu-list subtest.

Fixes: a84260e314029e6dc9904fd ("perf test stat_bpf_counters_cgrp: Enhance perf stat cgroup BPF counter test")
Signed-off-by: Michael Petlan <mpetlan@redhat.com>
Cc: vmolnaro@redhat.com
Cc: bpf@vger.kernel.org
Link: https://lore.kernel.org/r/20241101102812.576425-1-mpetlan@redhat.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/tests/shell/stat_bpf_counters_cgrp.sh

index e75d0780dc788acbb1cbd01fafe4401a26843b9e..2ec69060c42ffdc598e3b676706a705fb801e5b5 100755 (executable)
@@ -58,22 +58,9 @@ check_system_wide_counted()
        fi
 }
 
-check_cpu_list_counted()
-{
-       check_cpu_list_counted_output=$(perf stat -C 0,1 --bpf-counters --for-each-cgroup ${test_cgroups} -e cpu-clock -x, taskset -c 1 sleep 1  2>&1)
-       if echo ${check_cpu_list_counted_output} | grep -q -F "<not "; then
-               echo "Some CPU events are not counted"
-               if [ "${verbose}" = "1" ]; then
-                       echo ${check_cpu_list_counted_output}
-               fi
-               exit 1
-       fi
-}
-
 check_bpf_counter
 find_cgroups
 
 check_system_wide_counted
-check_cpu_list_counted
 
 exit 0