pinctrl: at91-pio4: drop useless check in atmel_conf_pin_config_dbg_show()

In atmel_conf_pin_config_dbg_show(), checking atmel_pioctrl->pins[pin_id]
against being NULL doesn't make any sense as it gets derefenced first and
the driver's probe() method immediately returns -ENOMEM when devm_kzalloc()
returns NULL for any atmel_pioctrl->pins[] element anyway, thus failing to
register the device...

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/4ab2f59f-45c1-76a2-94da-3331e8ec4e35@omp.ru
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
index 5d360ba3abc2ec03e6a5d87f6e72af37866b8945..383309e533c3d7c1a9bb5d1f6d9d9d1c586f8fac 100644 (file)
--- a/drivers/pinctrl/pinctrl-at91-pio4.c
+++ b/drivers/pinctrl/pinctrl-at91-pio4.c
@@ -939,10 +939,9 @@ static void atmel_conf_pin_config_dbg_show(struct pinctrl_dev *pctldev,
        if (!atmel_pioctrl->pins[pin_id]->device)
                return;
 
-       if (atmel_pioctrl->pins[pin_id])
-               seq_printf(s, " (%s, ioset %u) ",
-                          atmel_pioctrl->pins[pin_id]->device,
-                          atmel_pioctrl->pins[pin_id]->ioset);
+       seq_printf(s, " (%s, ioset %u) ",
+                  atmel_pioctrl->pins[pin_id]->device,
+                  atmel_pioctrl->pins[pin_id]->ioset);
 
        conf = atmel_pin_config_read(pctldev, pin_id);
        if (conf & ATMEL_PIO_PUEN_MASK)